-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically load api config and refactor the logger #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually quite liked that the logger configuration was specified in the config file, because everything was configured in a single place.
I see the issue of loading file before initializing logger, but it is not a big deal considering we want to exit the app when config loading fails.
af9dca4
to
915c4f7
Compare
@andreogle I've made two notable changes.
I will document the configuration in #56 |
915c4f7
to
ce26d48
Compare
ce26d48
to
9ed1d4b
Compare
This branch originally started out for getting the Cloudformation file setup, but I ended up using it for refactoring the config files based on the discussions. This work can continue separately.
Changes
logger
from both config files in favour of env variablesapi
package will now dynamically fetch and cache the logger based onCONFIG_SOURCE
. The data-pusher will follow the same pattern later.Let me know what you think