Rework and document configuration #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Sep 27, 2023
| @@ -38,7 +34,7 @@ defines two endpoints. The `/real-time` serves the non-delayed data, the latter | |||
| that has bee pushed in the last 15 seconds (configured by `delaySeconds` parameter). You can define multiple endpoints | |||
| as long as the `urlPath` is unique. | |||
|
|
|||
| ## Usage | |||
| ## API | |||
There was a problem hiding this comment.
I've (subjectively) reordered based on importance, similarly in the pusher.
| @@ -1,6 +1,17 @@ | |||
| <!-- TODO: Rename data-pusher workspace to pusher --> | |||
There was a problem hiding this comment.
I could do this now, but I am afraid of the conflicts so ideally will do this after other PRs are merged.
| import { go } from '@api3/promise-utils'; | ||
| import * as node from '@api3/airnode-node'; | ||
| import { unsafeEvaluate, unsafeEvaluateAsync } from './unsafe-evaluate'; | ||
|
|
||
| export const postProcessApiSpecifications = async (input: unknown, endpoint: Endpoint) => { |
There was a problem hiding this comment.
This is actually not needed.
Siegrift
force-pushed
the
rewamp-configuration
branch
from
bcea612 to
2e54cbe
Compare
Siegrift
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
Closes #54
Closes #14
My initial goal was to document the pusher package, but I realized there is no point in doing so before finishing the config changes (and I would need to redo the docs immediately). So I implemented the agreed config changes and made the documentation consistent with it.