Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added QRNG FAQ, CONTRIBUTING.md #635

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Added QRNG FAQ, CONTRIBUTING.md #635

merged 7 commits into from
Oct 10, 2023

Conversation

vanshwassan
Copy link
Contributor

  • Added FAQ as mentioned in this issue. Tried to revamp the getting started section to include both FAQ and the qrng-example repo within the same page.
  • Also added a CONTRIBUTING.md markdown for contributors to refer to before making a contribution.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Visit the preview URL for this PR (updated for commit 776b1b2):

https://vitepress-docs--pr635-qrng-faq-u34dcwll.web.app

(expires Fri, 13 Oct 2023 13:48:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

@vanshwassan vanshwassan changed the title Qrng faq Added QRNG FAQ, CONTRIBUTING.md Sep 29, 2023
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/guides/qrng/index.md Outdated Show resolved Hide resolved
docs/guides/qrng/index.md Show resolved Hide resolved
docs/guides/qrng/index.md Outdated Show resolved Hide resolved
docs/guides/qrng/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice FAQ additions. For CONTRIBUTING.md, the content overlaps some with https://docs.api3.org/dev/ - perhaps link to the relevant pages from the appropriate CONTRIBUTING.md sections?

@vanshwassan
Copy link
Contributor Author

Nice FAQ additions. For CONTRIBUTING.md, the content overlaps some with https://docs.api3.org/dev/ - perhaps link to the relevant pages from the appropriate CONTRIBUTING.md sections?

Ah I didn't know about this section, added references to this from CONTRIBUTING.md.

@vanshwassan vanshwassan requested a review from dcroote October 4, 2023 00:21
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few links need the trailing / removed, otherwise nice 👍

docs/guides/qrng/index.md Outdated Show resolved Hide resolved
docs/guides/qrng/index.md Outdated Show resolved Hide resolved
docs/guides/qrng/index.md Outdated Show resolved Hide resolved
@dcroote dcroote linked an issue Oct 4, 2023 that may be closed by this pull request
@dcroote
Copy link
Collaborator

dcroote commented Oct 10, 2023

Any reason not to merge?

@Ashar2shahid
Copy link
Contributor

Looks good, can get it merged

@Ashar2shahid Ashar2shahid merged commit 53a4fc7 into main Oct 10, 2023
2 checks passed
@Ashar2shahid Ashar2shahid deleted the qrng-faq branch October 10, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QRNG FAQ
3 participants