-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added QRNG FAQ, CONTRIBUTING.md
#635
Conversation
Visit the preview URL for this PR (updated for commit 776b1b2): https://vitepress-docs--pr635-qrng-faq-u34dcwll.web.app (expires Fri, 13 Oct 2023 13:48:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e4c5db1acb62b36273dc03718b86834917dea599 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice FAQ additions. For CONTRIBUTING.md
, the content overlaps some with https://docs.api3.org/dev/ - perhaps link to the relevant pages from the appropriate CONTRIBUTING.md
sections?
Ah I didn't know about this section, added references to this from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few links need the trailing /
removed, otherwise nice 👍
Any reason not to merge? |
Looks good, can get it merged |
CONTRIBUTING.md
markdown for contributors to refer to before making a contribution.