Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update qrng provider nodary #641

Merged
merged 8 commits into from
Oct 10, 2023
Merged

Update qrng provider nodary #641

merged 8 commits into from
Oct 10, 2023

Conversation

metobom
Copy link
Member

@metobom metobom commented Oct 6, 2023

Since testnet random numbers are not operator by Nodary anymore, I updated the docs.

@metobom metobom requested a review from Ashar2shahid October 6, 2023 10:12
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit d7faba1):

https://vitepress-docs--pr641-update-qrng-provider-znbjre6f.web.app

(expires Mon, 16 Oct 2023 12:57:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

dcroote
dcroote requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a dedicated chains page for listing the chains, can you update that instead of the added table?

Nodary is also mentioned elsewhere e.g. in guides, can you make the name change there as well?

@metobom metobom requested a review from dcroote October 9, 2023 12:55
@metobom
Copy link
Member Author

metobom commented Oct 9, 2023 •
edited
Loading

There is a problem in this page. The page uses @api3/chains and @api3/chains does not export any chain with id 77.

image

@dcroote dcroote mentioned this pull request Oct 10, 2023
Closed
dcroote
dcroote approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the updates. Since the missing POA Network Sokol testnet name is an ongoing separate issue, I opened #644, nice catch 👍

@metobom metobom merged commit 42957b8 into main Oct 10, 2023
2 checks passed
@metobom metobom deleted the update-qrng-provider-nodary branch October 10, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcroote dcroote dcroote approved these changes

@Ashar2shahid Ashar2shahid Awaiting requested review from Ashar2shahid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metobom @dcroote