625 flex file sizes note dev #647

wkande · 2023-10-12T11:43:21Z

Close #625

This most addresses file sizes when running yarn flex:build. The sizes of the 3 map.json files should be verified.

github-actions · 2023-10-12T11:45:32Z

Visit the preview URL for this PR (updated for commit b49ca2e):

https://vitepress-docs--pr647-625-flex-file-sizes-vr7bhy3a.web.app

_{(expires Thu, 19 Oct 2023 11:45:11 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: e4c5db1acb62b36273dc03718b86834917dea599}

dcroote

LGTM. @vanshwassan note the tags frontmatter format (which I didn't catch either)

wkande · 2023-10-12T18:59:20Z

Frontmatter tags look like this:

---
title: Getting Started with QRNG
sidebarHeader: Guides
sidebarSubHeader:
pageHeader: Guides → QRNG
path: /guides/qrng/index.html
outline: deep
tags:
  - qrng
  - getting started
---

wkande added 3 commits October 12, 2023 05:40

Add note about flex_build file sizes

0c4ff16

fix broken frontmatter tag on qrng intro

e6e9c47

update flex indexes

b49ca2e

wkande requested review from dcroote and Ashar2shahid October 12, 2023 11:43

wkande self-assigned this Oct 12, 2023

dcroote approved these changes Oct 12, 2023

View reviewed changes

wkande merged commit aa806aa into main Oct 12, 2023
2 checks passed

wkande deleted the 625-flex-file-sizes-note-dev branch October 12, 2023 19:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

625 flex file sizes note dev #647

625 flex file sizes note dev #647

wkande commented Oct 12, 2023

github-actions bot commented Oct 12, 2023

dcroote left a comment

wkande commented Oct 12, 2023

625 flex file sizes note dev #647

625 flex file sizes note dev #647

Conversation

wkande commented Oct 12, 2023

github-actions bot commented Oct 12, 2023

dcroote left a comment

Choose a reason for hiding this comment

wkande commented Oct 12, 2023