Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

648 618 framework update all external links #655

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

wkande
Copy link
Member

@wkande wkande commented Oct 30, 2023

Closes #648
Closes #618

The framework updated to rc.24
Native ExternalLinkIcon added to themeConfig in the config file
All references to the custom ExternalLinkImage compoonent removed

Going forward any link with a protocol included (http, e.t.c) will get an arrow place after the link text by VitePress automaticaly.

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 497d190):

https://vitepress-docs--pr655-648-618-framework-up-ol4s8bzo.web.app

(expires Mon, 06 Nov 2023 22:10:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comment before a review: I think you mean this PR closes issue 618 not 614?

Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me - I clicked around on internal links, external links, searched, and everything worked fine.

@wkande wkande merged commit 68775f8 into main Oct 31, 2023
2 checks passed
@wkande wkande deleted the 648-618-framework-update-AND-externallinks branch October 31, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade vitepress framework to rc.24 Replace external link component with Vitepress default action
2 participants