Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dAPI Getting Started page #661

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Added dAPI Getting Started page #661

merged 6 commits into from
Nov 17, 2023

Conversation

vanshwassan
Copy link
Contributor

  • Added a dAPI Getting Started page in the same style as QRNG Getting Started.
  • Moved the dAPI subscribing guides under a separate sub-section within the dAPI sidebar.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8c65365):

https://vitepress-docs--pr661-dapi-getting-started-zxmyh7e2.web.app

(expires Mon, 20 Nov 2023 23:26:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

Ashar2shahid
Ashar2shahid approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@Ashar2shahid Ashar2shahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dcroote
dcroote reviewed Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor grammar comment

docs/guides/dapis/index.md Outdated Show resolved Hide resolved
@wkande
Copy link
Member

wkande commented Nov 13, 2023 •
edited
Loading

Also there is the need to update the pageHeader field in the front matter for the following two files because they are now nested into a new folder in the sidebar.

title: Subscribing to Self-Funded dAPIs
...
- pageHeader: Guides → dAPIs
+ pageHeader: Guides → dAPIs → Subscribing to dAPIs

title: Subscribing to Managed dAPIs
...
- pageHeader: Guides → dAPIs
+ pageHeader: Guides → dAPIs → Subscribing to dAPIs

@vanshwassan vanshwassan merged commit 3121878 into main Nov 17, 2023
2 checks passed
@vanshwassan vanshwassan deleted the dapi-getting-started branch November 17, 2023 09:53
@wkande wkande mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcroote dcroote dcroote left review comments

@Ashar2shahid Ashar2shahid Ashar2shahid approved these changes

@wkande wkande Awaiting requested review from wkande

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vanshwassan @wkande @dcroote @Ashar2shahid