Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20231209 run axios script #680

Merged
merged 3 commits into from
Dec 9, 2023
Merged

20231209 run axios script #680

merged 3 commits into from
Dec 9, 2023

Conversation

wkande
Copy link
Member

@wkande wkande commented Dec 9, 2023

This is necessary to get the new addresses for Api3ServerV1 published. Sorry but please review post merge. I needed to get this out.

Also note the removal of the addresses for requesterauthorizerwitherc721. I was told this is no longer used so I removed it from the Airnode contracts list. There is still a presence of this contract in the docs regarding its use. I will create a new issue to remove it. See the conversation from Slack below.

Warren

When I run the Axios script no addresses return for the contract RequesterAuthorizerWithErc721. This is for Airnode and not for dAPIs. Is the contract gone? It used to return the following: ...

From what I can see the answer is yes because the key for it is empty in https://raw.githubusercontent.com/api3dao/airnode-protocol-v1/main/deployments/references.json:

Burak

Yes, it’s gone. We were weren’t using it anyway so you can remove all reference to it.

@wkande wkande self-assigned this Dec 9, 2023
Copy link
Contributor

github-actions bot commented Dec 9, 2023

Visit the preview URL for this PR (updated for commit 47ac26f):

https://vitepress-docs--pr680-20231209-run-axios-s-hzxrtaam.web.app

(expires Sat, 16 Dec 2023 21:21:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

@wkande wkande merged commit 612df90 into main Dec 9, 2023
2 checks passed
@wkande wkande deleted the 20231209-run-axios-script branch December 9, 2023 21:25
Copy link
Collaborator

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize you already merged, but the changes LGTM. I ran axios:build after pulling these latest changes and nothing updated, so 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants