fix(json-schema): Allow $ref in the root of a definitions object

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Fury Swagger Parser Changelog
 
+## Master
+
+- Fixes a regression introduced in 0.22.0 where using `$ref` directly inside a
+  Swagger Schema found within the `definitions` section would cause a parsing
+  failure.
+
 ## 0.22.1 (2018-10-22)
 
 ### Bug Fixes

src/json-schema.js

@@ -257,7 +257,7 @@ export function convertSchema(schema, root, swagger, copyDefinitions = true) {
     }
   }
 
-  if (result.$ref) {
+  if (result.$ref && copyDefinitions) {
     const reference = lookupReference(result.$ref, root);
 
     if (!checkSchemaHasReferences(result.definitions[reference.id])) {

test/json-schema.js

@@ -3,7 +3,7 @@
 
 import { expect } from 'chai';
 
-import { convertSchema } from '../src/json-schema';
+import { convertSchema, convertSchemaDefinitions } from '../src/json-schema';
 
 describe('Swagger Schema to JSON Schema', () => {
   it('returns compatible schema when given valid JSON Schema', () => {
@@ -552,4 +552,41 @@ describe('Swagger Schema to JSON Schema', () => {
       });
     });
   });
+
+  describe('converting JSON Schema definitions', () => {
+    it('can convert a Swagger Schema definitions section', () => {
+      const result = convertSchemaDefinitions({
+        User: {
+          type: 'object',
+          'x-extension': true,
+        },
+      });
+
+      expect(result).to.deep.equal({
+        User: {
+          type: 'object',
+        },
+      });
+    });
+
+    it('can convert a Swagger Schema definition with root reference', () => {
+      const result = convertSchemaDefinitions({
+        Base: {
+          type: 'object',
+        },
+        User: {
+          $ref: '#/definitions/Base',
+        },
+      });
+
+      expect(result).to.deep.equal({
+        Base: {
+          type: 'object',
+        },
+        User: {
+          $ref: '#/definitions/Base',
+        },
+      });
+    });
+  });
 });