Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Symfony 7.1 upgrade #381

Open
wants to merge 5 commits into
base: 4.x
Choose a base branch
from

Conversation

kedarkhaire
Copy link
Collaborator

@kedarkhaire kedarkhaire commented Sep 30, 2024

Fixes #354

@kedarkhaire kedarkhaire added this to the 3.0.8 milestone Sep 30, 2024
@kedarkhaire kedarkhaire marked this pull request as draft October 1, 2024 10:35
@kedarkhaire kedarkhaire changed the base branch from 3.x to 4.x October 7, 2024 13:35
@kedarkhaire kedarkhaire marked this pull request as ready for review October 7, 2024 13:46
@kedarkhaire kedarkhaire changed the title Fixes for psalm errors post Symfony 7.1 upgrade Changes for Symfony 7.1 upgrade Oct 14, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.68%. Comparing base (f43f83e) to head (7da33c3).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x     #381      +/-   ##
============================================
- Coverage     86.81%   86.68%   -0.14%     
+ Complexity     1768     1737      -31     
============================================
  Files           349      343       -6     
  Lines          4643     4220     -423     
============================================
- Hits           4031     3658     -373     
+ Misses          612      562      -50     
Flag Coverage Δ
unittests 86.68% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 114 files with indirect coverage changes

@@ -11,10 +11,6 @@ jobs:
strategy:
matrix:
include:
- php: '8.1'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kedarkhaire rather than removing 8.1 check if you can skip the version for symfony 7.

@kedarkhaire kedarkhaire modified the milestones: 3.0.8, 4.0.0 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for symfony 7
3 participants