Drupal 10.3 testcases added in workflow & fix for missing CACHE_MISS_…

…IF_UNCACHEABLE_HTTP_METHOD tag is added (#501)
apigee · Oct 1, 2024 · a9b6fcf · a9b6fcf
1 parent f8e8c85
commit a9b6fcf
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 0 deletions.
diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml
@@ -38,6 +38,7 @@ jobs:
         drupal-core:
           # Should update the following as the minimum supported version from Drupal.org
           - "10.2.x"
+          - "10.3.x"
         instance-type:
           - "Edge"
           - "X"

diff --git a/src/Controller/PrepaidBalanceControllerBase.php b/src/Controller/PrepaidBalanceControllerBase.php
@@ -325,6 +325,7 @@ protected function getDataFromCache(EntityInterface $entity, string $suffix, cal
    */
   public static function getCacheTags(EntityInterface $entity) {
     return [
+      static::CACHE_MISS,
       static::CACHE_PREFIX,
       static::getCacheId($entity),
     ];

diff --git a/src/Controller/PrepaidBalanceControllerInterface.php b/src/Controller/PrepaidBalanceControllerInterface.php
@@ -30,6 +30,12 @@
  */
 interface PrepaidBalanceControllerInterface {
 
+  /**
+   * Cache prefix is new 'reserved' cache tag format CACHE_MISS_IF_UNCACHEABLE_HTTP_METHOD:$suffix,
+   * if something is tagged with this, it will be a cache miss on POST requests.
+   */
+  const CACHE_MISS = 'CACHE_MISS_IF_UNCACHEABLE_HTTP_METHOD:form';
+
   /**
    * Cache prefix that is used for cache tags for this controller.
    */

diff --git a/src/Controller/PrepaidBalanceXControllerBase.php b/src/Controller/PrepaidBalanceXControllerBase.php
@@ -320,6 +320,7 @@ protected function getDataFromCache(EntityInterface $entity, string $suffix, cal
    */
   public static function getCacheTags(EntityInterface $entity) {
     return [
+      static::CACHE_MISS,
       static::CACHE_PREFIX,
       static::getCacheId($entity),
     ];

diff --git a/src/Controller/PrepaidBalanceXControllerInterface.php b/src/Controller/PrepaidBalanceXControllerInterface.php
@@ -30,6 +30,12 @@
  */
 interface PrepaidBalanceXControllerInterface {
 
+  /**
+   * Cache prefix is new 'reserved' cache tag format CACHE_MISS_IF_UNCACHEABLE_HTTP_METHOD:$suffix,
+   * if something is tagged with this, it will be a cache miss on POST requests.
+   */
+  const CACHE_MISS = 'CACHE_MISS_IF_UNCACHEABLE_HTTP_METHOD:form';
+
   /**
    * Cache prefix that is used for cache tags for this controller.
    */