Skip to content

Latest commit

 

History

History
157 lines (127 loc) · 6.11 KB

PodProxyOptionsTest.org

File metadata and controls

157 lines (127 loc) · 6.11 KB
Raw

Write PodProxyOptions Mock Test

Progress [1/6]

  • [X] APISnoop org-flow : PodProxyOptionsTest.org
  • [ ] test approval issue : kubernetes/kubernetes#
  • [ ] test pr : kuberenetes/kubernetes#
  • [ ] two weeks soak start date : testgrid-link
  • [ ] two weeks soak end date :
  • [ ] test promotion pr : kubernetes/kubernetes#?

Identifying an untested feature Using APISnoop

According to this APIsnoop query, there are still some remaining PodProxyOptions endpoints which are untested.

SELECT
  operation_id,
  -- k8s_action,
  -- path,
  description,
  kind
  FROM untested_stable_core_endpoints
  -- FROM untested_stable_endpoints
  where path not like '%volume%'
  and kind like 'PodProxyOptions'
  -- and operation_id ilike '%%'
 ORDER BY kind,operation_id desc
 LIMIT 25
       ;

                  operation_id                  |               description                |      kind       
------------------------------------------------+------------------------------------------+-----------------
 connectCoreV1PutNamespacedPodProxyWithPath     | connect PUT requests to proxy of Pod     | PodProxyOptions
 connectCoreV1PutNamespacedPodProxy             | connect PUT requests to proxy of Pod     | PodProxyOptions
 connectCoreV1PostNamespacedPodProxyWithPath    | connect POST requests to proxy of Pod    | PodProxyOptions
 connectCoreV1PostNamespacedPodProxy            | connect POST requests to proxy of Pod    | PodProxyOptions
 connectCoreV1PatchNamespacedPodProxyWithPath   | connect PATCH requests to proxy of Pod   | PodProxyOptions
 connectCoreV1PatchNamespacedPodProxy           | connect PATCH requests to proxy of Pod   | PodProxyOptions
 connectCoreV1OptionsNamespacedPodProxyWithPath | connect OPTIONS requests to proxy of Pod | PodProxyOptions
 connectCoreV1OptionsNamespacedPodProxy         | connect OPTIONS requests to proxy of Pod | PodProxyOptions
 connectCoreV1HeadNamespacedPodProxyWithPath    | connect HEAD requests to proxy of Pod    | PodProxyOptions
 connectCoreV1HeadNamespacedPodProxy            | connect HEAD requests to proxy of Pod    | PodProxyOptions
 connectCoreV1GetNamespacedPodProxy             | connect GET requests to proxy of Pod     | PodProxyOptions
 connectCoreV1DeleteNamespacedPodProxyWithPath  | connect DELETE requests to proxy of Pod  | PodProxyOptions
 connectCoreV1DeleteNamespacedPodProxy          | connect DELETE requests to proxy of Pod  | PodProxyOptions
(13 rows)

Looking for feedback on what direction should be taken with these endpoints and the best method for testing them.

API Reference and feature documentation

The mock test

Test outline

1.

2.

3.

4.

5.

Test the functionality in Go

package main

import (
  "fmt"
  "context"
  "flag"
  "os"
  v1 "k8s.io/api/core/v1"
  metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
  "k8s.io/client-go/kubernetes"
  "k8s.io/client-go/tools/clientcmd"
)

func main() {
  // uses the current context in kubeconfig
  kubeconfig := flag.String("kubeconfig", fmt.Sprintf("%v/%v/%v", os.Getenv("HOME"), ".kube", "config"), "(optional) absolute path to the kubeconfig file")
  flag.Parse()
  config, err := clientcmd.BuildConfigFromFlags("", *kubeconfig)
  if err != nil {
      fmt.Println(err, "Could not build config from flags")
      return
  }
  // make our work easier to find in the audit_event queries
  config.UserAgent = "live-test-writing"
  // creates the clientset
  ClientSet, _ := kubernetes.NewForConfig(config)

  // TEST BEGINS HERE


  // TEST ENDS HERE

  fmt.Println("[status] complete")

}

Verifying increase in coverage with APISnoop

Discover useragents:

select distinct useragent from audit_event where bucket='apisnoop' and useragent not like 'kube%' and useragent not like 'coredns%' and useragent not like 'kindnetd%' and useragent like 'live%';

List endpoints hit by the test:

select * from endpoints_hit_by_new_test where useragent like 'live%';

Display endpoint coverage change:

select * from projected_change_in_coverage;

   category    | total_endpoints | old_coverage | new_coverage | change_in_number
---------------+-----------------+--------------+--------------+------------------
 test_coverage |             438 |          183 |          183 |                0
(1 row)

Final notes

If a test with these calls gets merged, **test coverage will go up by N points**

This test is also created with the goal of conformance promotion.

/sig testing

/sig architecture

/area conformance