Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query planner cache key improvements #6206

Merged
merged 95 commits into from
Nov 5, 2024

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Oct 29, 2024

Fix #5160

This splits part of the work from #5255 to make it easier to merge.
This covers improvements and fixes to the query planner cache key from changes related to the query hashing algorithm and query plan reuse during warmup.

Fixed:

  • use prefixes for each part of the redis cache key so they become self describing
  • remove the custom Hash implementation for the cache key
  • remove JSON serialization
  • hash the Rust planner's config only once, not on every cache query

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@Geal Geal requested review from a team as code owners October 29, 2024 10:20
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 29, 2024

✅ Docs Preview Ready

No new or changed pages found.

@router-perf
Copy link

router-perf bot commented Oct 29, 2024

CI performance tests

  • connectors-const - Connectors stress test that runs with a constant number of users
  • const - Basic stress test that runs with a constant number of users
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • enhanced-signature - Enhanced signature enabled
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • extended-reference-mode - Extended reference mode enabled
  • large-request - Stress test with a 1 MB request payload
  • no-tracing - Basic stress test, no tracing
  • reload - Reload test over a long period of time at a constant rate of users
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • step-local-metrics - Field stats that are generated from the router rather than FTV1
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • step - Basic stress test that steps up the number of users over time
  • xlarge-request - Stress test with 10 MB request payload
  • xxlarge-request - Stress test with 100 MB request payload

This comment has been minimized.

Geal and others added 2 commits November 4, 2024 11:53
Co-authored-by: Renée <renee.kooi@apollographql.com>
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a small naming nit.

apollo-router/src/query_planner/caching_query_planner.rs Outdated Show resolved Hide resolved
@Geal Geal enabled auto-merge (squash) November 5, 2024 08:48
@Geal Geal disabled auto-merge November 5, 2024 08:48
@Geal Geal enabled auto-merge (squash) November 5, 2024 08:49
@Geal Geal merged commit 36bdb5e into dev Nov 5, 2024
13 of 14 checks passed
@Geal Geal deleted the geal/query-planner-cache-key-improvements branch November 5, 2024 16:23
LongLiveCHIEF pushed a commit to StateFarmIns/router that referenced this pull request Nov 21, 2024
Fix apollographql#5160

This splits part of the work from apollographql#5255 to make it easier to merge.
This covers improvements and fixes to the query planner cache key from changes related to the query hashing algorithm and query plan reuse during warmup.

Fixed:
* use prefixes for each part of the redis cache key so they become self describing
* remove the custom Hash implementation for the cache key
* remove JSON serialization
* hash the Rust planner's config only once, not on every cache query

Co-authored-by: Ivan Goncharov <ivan.goncharov.ua@gmail.com>
Co-authored-by: Jeremy Lempereur <jeremy.lempereur@iomentum.com>
Co-authored-by: Gary Pennington <gary@apollographql.com>
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: Renée <renee.kooi@apollographql.com>
@abernix abernix mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query plan cache key follow up
6 participants