Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ranger Discovery Bundle and Lib Version upgrades #29

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Ranger Discovery Bundle and Lib Version upgrades #29

merged 2 commits into from
Dec 6, 2023

Conversation

koushikr
Copy link
Collaborator

@koushikr koushikr commented Nov 30, 2023 •
edited
Loading

  • Moved discovery bundle from here
  • Updated to dropwizard version 2.1.10 : BOM update.
  • Upgraded to java source, target version 17 with release in 11
  • Removed com.fasterxml and introduced dropwizard-jackson for the jackson bindings.
  • Upgraded to junit 5 and fixed the necessary tests including wiremock versions and tests. (100+ files changed because of this)
  • Upgraded the curator framework version
  • Done sonar fixes after the java version upgrade
  • Updated the release version
  • Updated CHANGELOG.md
  • Updated the build.yml to use java17
  • Removed logback dependency since dropwizard already has it.
  • Fixed the maven javadoc version to 3.6.3. For this

Callouts

  • Can't do much about the netty-handler vulnerability, even the latest netty version is burdened by it.
  • Can't also do much about the snakeyaml vulnerability. Seems like dw 2.1.10 is not compatible with snakeyaml 2.x.

@koushikr
a) Moved discovery bundle from https://github.com/appform-io/dropwiza…
614b8e9 
…rd-service-discovery.

b) Updated to dropwizard version 2.1.10
c) Upgraded to java version 17 with release in 11
d) Removed com.fasterxml and introduced dropwizard-jackson for the jackson bindings.
e) Upgraded the curator framework version, added necessary exclusions for the libs with vulnerabilities (netty-codec)
f) Fixed the vulnerable snakeyaml that was coming from io.dropwizard to an updated version
g) Upgraded to junit 5 and fixed the necessary tests including wiremock versions and tests.
h) Done sonar fixes in tests after g
@koushikr koushikr marked this pull request as draft November 30, 2023 12:34
@koushikr koushikr marked this pull request as ready for review November 30, 2023 12:34
@koushikr koushikr changed the title [Draft] Ranger Discovery Bundle and Lib Version upgrades Ranger Discovery Bundle and Lib Version upgrades Nov 30, 2023
@santanusinha santanusinha self-requested a review December 6, 2023 03:26
santanusinha
santanusinha requested changes Dec 6, 2023
View reviewed changes
.github/workflows/build-check.yml Outdated Show resolved Hide resolved
ranger-core/src/test/java/io/appform/ranger/core/serviceprovider/ServiceProviderTest.java Outdated Show resolved Hide resolved
ranger-core/src/test/java/io/appform/ranger/core/serviceprovider/ServiceProviderTest.java Outdated Show resolved Hide resolved
ranger-discovery-bundle/src/main/java/io/appform/ranger/discovery/bundle/id/IdGenerator.java Show resolved Hide resolved
.../java/io/appform/ranger/discovery/bundle/ServiceDiscoveryBundleHierarchicalSelectorTest.java Show resolved Hide resolved
ranger-http-server/pom.xml Outdated Show resolved Hide resolved
ranger-server-bundle/src/test/java/io/appform/ranger/server/bundle/RangerServerBundleTest.java Outdated Show resolved Hide resolved
ranger-zk-server/config/local.yml Outdated Show resolved Hide resolved
ranger-zk-server/config/local.yml Outdated Show resolved Hide resolved
ranger-zk-server/config/local.yml Outdated Show resolved Hide resolved
@koushikr koushikr marked this pull request as draft December 6, 2023 08:54
@koushikr koushikr force-pushed the main branch 9 times, most recently from 878b079 to 98c0109 Compare December 6, 2023 10:14
@koushikr koushikr marked this pull request as ready for review December 6, 2023 10:21
@koushikr koushikr force-pushed the main branch 5 times, most recently from f5364cc to f8b7354 Compare December 6, 2023 11:21
@koushikr koushikr marked this pull request as draft December 6, 2023 11:21
@koushikr
a) local.yml hs internal values, fixed them
d3dad6d 
    b) static final attributes made UPPER_SNAKE format
    c) Removed logback since dw has it already
    d) Removed the unnecessary AfterEach
    e) Fixed exception handling for junit5
    f) Moved build-check.yml java version to 17 from 11
@koushikr koushikr marked this pull request as ready for review December 6, 2023 11:31
@santanusinha santanusinha merged commit e934487 into appform-io:main Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santanusinha santanusinha santanusinha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koushikr @santanusinha