-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add all the types #635
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
bce5c83
to
2d7231c
Compare
I cannot review the PR, - it's too big 🤷 |
both the functional test and unit test workflows had a job called "test" which was confusing act
also tweak some tests
- also upgrades chromedriver - fixes some broken types - re-add `source-map-support`
OK @mykola-mokhnach I merged in master and made all the required fixes. Let's see what tests say. |
tests seem reasonably ok. propose that we merge and cut a beta release and get people to test it out |
@jlipps Yes, lets do it. Do you also have a similar PR for Espresso? |
@mykola-mokhnach no, nothing for Espresso yet. We'll need to work on that one from scratch. Or does it rely on the uia2 driver at all? Also, I am on PTO monday so I don't think it's a good idea for me to merge and publish. I'm also not sure if there is some kind of auto release script on this repo. Do you want to handle the mechanics of the beta release? |
This repo has autorelease based on conventional commits (e.g. PR title and description). It makes sense to release the driver if you are around, so please do it before you know you will be available for a while. |
## [2.30.0](v2.29.11...v2.30.0) (2023-10-13) ### Features * add all the types ([#635](#635)) ([623f49b](623f49b))
🎉 This PR is included in version 2.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I have error "Error: Failed to create session. A new session could not be created. Details: 'app' can't be blank" on this version, when i try make session. |
#641 is actually problem in this version |
@pavlo-dot-dev Please report your issue to the appropriate tracker and add the environment info plus server logs |
Disclaimer - First time poster - @boneskull I tried to move from uiautomator2@2.29.9 to the latest (uiautomator2@2.43.4) this version appears to be where driver.executeScript("mobile: deviceInfo", "networks") starts throwing errors for me. Was this collateral or an unreported issue? Sorry if it's been previous addressed I did try to look and search and didn't find any mention. |
|
@KazuCocoa thanks for steer - shouldn't really have needed it but here we are - taking out "networks" got me back what I used to use / needs. Thanks! |
this depends on appium/appium#18817 and appium/appium-android-driver#819.
createSession
, I renamed some of the methods it calls and attempted to otherwise make things more clear.createSession
returns an object which is a superset of the user-defined capabilities, since it adds a bunch of device info. seelib/types.ts
for the type definitions of these objects;createSession
responds with a capabilities object of typeUiautomator2SessionCaps
fillDeviceDetails
togetDeviceDetails
and hopefully made it faster by running the async operations in parallel.initUiautomator2Server
returns theUiautomator2Server
instance (which we consume) so we know the value is defined. otherwise it still mutates the instance.classes can use the
CreateResult
type argument when extendingBaseDriver
and implementingExternalDriver
to resolve with a custom value; if unset, the returned capabilities will contain only props as defined in the driver's constraints (plus any "base" constraints).