Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sun disc. #2866

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add sun disc. #2866

wants to merge 8 commits into from

Conversation

mororo250
Copy link
Contributor

@mororo250 mororo250 commented May 22, 2020 •
edited
Loading

This is a draft because #2811 is still open.

@mororo250 mororo250 changed the title Sun disc Add Sun disc. May 22, 2020
@mororo250 mororo250 changed the title Add Sun disc. Add sun disc. May 22, 2020
@mororo250 mororo250 force-pushed the Sun_disc branch 8 times, most recently from e9c9782 to 26a9527 Compare May 28, 2020 02:44
@mororo250 mororo250 force-pushed the Sun_disc branch 5 times, most recently from 331e133 to 046aa51 Compare June 29, 2020 19:22
@mororo250 mororo250 marked this pull request as ready for review June 29, 2020 19:23
dictoon
dictoon requested changes Jun 30, 2020
View reviewed changes
Copy link
Member

@dictoon dictoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

This PR is problematic on many aspects. It will need to be deeply reworked before we can consider merging it.

Let's discuss on Discord!

src/appleseed/renderer/modeling/light/light.h Outdated Show resolved Hide resolved
src/appleseed/renderer/modeling/light/light.h Outdated Show resolved Hide resolved
src/appleseed/renderer/modeling/light/light.cpp Outdated Show resolved Hide resolved
src/appleseed/renderer/kernel/shading/shadingengine.cpp Outdated Show resolved Hide resolved
src/appleseed/renderer/kernel/shading/shadingengine.cpp Outdated Show resolved Hide resolved
src/appleseed/renderer/modeling/light/sunlight.cpp Outdated Show resolved Hide resolved
src/appleseed/renderer/modeling/light/sunlight.cpp Outdated Show resolved Hide resolved
src/appleseed/renderer/modeling/light/sunlight.cpp Outdated Show resolved Hide resolved
src/appleseed/renderer/modeling/light/sunlight.cpp Outdated Show resolved Hide resolved
src/appleseed/renderer/modeling/light/sunlight.cpp Outdated Show resolved Hide resolved
@mororo250 mororo250 force-pushed the Sun_disc branch 4 times, most recently from f9000f7 to abfbae0 Compare July 4, 2020 04:03
@mororo250 mororo250 force-pushed the Sun_disc branch 2 times, most recently from 74b9f3d to 5035b89 Compare July 10, 2020 02:40
@mororo250 mororo250 force-pushed the Sun_disc branch 2 times, most recently from e77aa69 to 76d1aa6 Compare August 31, 2020 16:39
@joelbarmettlerUZH joelbarmettlerUZH mentioned this pull request Jan 7, 2021
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dictoon dictoon dictoon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mororo250 @dictoon