Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace configuring of LDAP service with Keycloak service #337

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

DebakelOrakel
Copy link
Contributor

No description provided.

@DebakelOrakel DebakelOrakel added the documentation Improvements or additions to documentation label Jun 24, 2024
@DebakelOrakel DebakelOrakel requested a review from a team June 24, 2024 06:37
Copy link
Member

@haasad haasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to tidy up all old services, firewall rules etc as part of your current migration work?

Then we could also remove the following sections:

# delete ldap secret
vault kv delete clusters/kv/${TENANT_ID}/${CLUSTER_ID}/vshn-ldap

. Remove IPs from LDAP allowlist
+
Edit https://git.vshn.net/vshn-puppet/vshn_hieradata/-/blob/master/corp/prod/ldap.yaml
+
- Search cluster IPs and remove those lines and any comments related.
+
- Create a Merge Request and invite a colleague for a review/approve/merge

. Remove cluster IPs from LDAP allowlist, if applicable

Also:

@DebakelOrakel
Copy link
Contributor Author

Are we going to tidy up all old services, firewall rules etc as part of your current migration work?

Then we could also remove the following sections:

# delete ldap secret
vault kv delete clusters/kv/${TENANT_ID}/${CLUSTER_ID}/vshn-ldap

. Remove IPs from LDAP allowlist
+
Edit https://git.vshn.net/vshn-puppet/vshn_hieradata/-/blob/master/corp/prod/ldap.yaml
+
- Search cluster IPs and remove those lines and any comments related.
+
- Create a Merge Request and invite a colleague for a review/approve/merge

. Remove cluster IPs from LDAP allowlist, if applicable

Also:

This was pretty much all done a while back.

@DebakelOrakel DebakelOrakel merged commit 53cc8df into master Jun 24, 2024
1 check passed
@DebakelOrakel DebakelOrakel deleted the install/remove-ldap branch June 24, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants