-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] - Resource Count Delection Skipping #1194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gambol99
force-pushed
the
feat_zero_block
branch
from
January 18, 2024 18:59
3abd346
to
f24b418
Compare
When then configuration has not provisioned any ressources, we can skip the deletion job
gambol99
force-pushed
the
feat_zero_block
branch
from
January 18, 2024 19:00
f24b418
to
cda8d93
Compare
Related to #1187 |
Fixed up as suggested in fb63ce6 @KashifSaadat |
KashifSaadat
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!!
gambol99
added a commit
that referenced
this pull request
Jan 23, 2024
* [FEATURE] - Resource Count Delection Skipping When then configuration has not provisioned any ressources, we can skip the deletion job * fix: adding the suggested amendments * chore: adding a fake dummy module, that does nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When then configuration has not provisioned any ressources, we can skip the deletion job