Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Executor Resource Requests & Limits #1501

Merged
merged 4 commits into from
Aug 31, 2024

Conversation

gambol99
Copy link
Member

@gambol99 gambol99 commented Aug 30, 2024

Currently consumers are not permitted to set the executor resource requests/limits - this has created an error in the past, due to higher than expected requirements, hence it was bumped to 1Gi. For certain modules though this may not be enough, hence the feature to support controling the fields from the controller arguments

[jest@razor terranetes-controller]$ bin/controller --help | egrep '(request|limit)' -i
      --executor-cpu-limit string            The default CPU limit for the executor container (default "1")
      --executor-cpu-request string          The default CPU request for the executor container (default "5m")
      --executor-memory-limit string         The default memory limit for the executor container (default "1Gi")
      --executor-memory-request string       The default memory request for the executor container (default "32Mi")

Note: the user can technically overload the template using the method described here https://terranetes.appvia.io/terranetes-controller/admin/template/ … but that is largely for last ditch effort, as it comes was compatibility issues going forward.

Currently consumers are not permitted to set the executor resource requests/limits - this has created an error in the past, due to higher than expected requirements, hence it was bumped to 1Gi. For certain modules though this may not be enough, hence the feature to support controling the fields from the controller arguments
@gambol99 gambol99 changed the title [FEAT] - Executor Resource Requests & Limits [FEATURE] - Executor Resource Requests & Limits Aug 30, 2024
@gambol99 gambol99 linked an issue Aug 30, 2024 that may be closed by this pull request
@gambol99 gambol99 added the enhancement New feature or request label Aug 30, 2024
@gambol99 gambol99 self-assigned this Aug 30, 2024
@@ -260,11 +260,11 @@ spec:
{{- end }}
resources:
limits:
cpu: 1
memory: 1Gi
cpu: {{ .DefaultExecutorCPULimit }}
Copy link
Member

@KashifSaadat KashifSaadat Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick, not important): Perhaps leave off the CPU default limit (make it conditional, so if set to a custom value only then will it be specified in the template).

Copy link
Member Author

@gambol99 gambol99 Aug 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we prefer fec8d22 .. and place the decision solely on the administrator? cc @KashifSaadat

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry rebased - 9ddbaaf

Copy link
Member

@KashifSaadat KashifSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gambol99 gambol99 merged commit b488ca7 into develop Aug 31, 2024
14 checks passed
@gambol99 gambol99 deleted the feat_executor_resources branch August 31, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to customize Job template resources
3 participants