-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] - Executor Resource Requests & Limits #1501
Conversation
Currently consumers are not permitted to set the executor resource requests/limits - this has created an error in the past, due to higher than expected requirements, hence it was bumped to 1Gi. For certain modules though this may not be enough, hence the feature to support controling the fields from the controller arguments
@@ -260,11 +260,11 @@ spec: | |||
{{- end }} | |||
resources: | |||
limits: | |||
cpu: 1 | |||
memory: 1Gi | |||
cpu: {{ .DefaultExecutorCPULimit }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nitpick, not important): Perhaps leave off the CPU default limit (make it conditional, so if set to a custom value only then will it be specified in the template).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we prefer fec8d22 .. and place the decision solely on the administrator? cc @KashifSaadat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry rebased - 9ddbaaf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…the administrator as to limits
fec8d22
to
9ddbaaf
Compare
Currently consumers are not permitted to set the executor resource requests/limits - this has created an error in the past, due to higher than expected requirements, hence it was bumped to 1Gi. For certain modules though this may not be enough, hence the feature to support controling the fields from the controller arguments
Note: the user can technically overload the template using the method described here https://terranetes.appvia.io/terranetes-controller/admin/template/ … but that is largely for last ditch effort, as it comes was compatibility issues going forward.