Fix returncode when deleting a mirror with snapshot

When trying to delete a mirror that has snapshot and not providing the force option, the API should not return a `500 StatusInternalServerError`. A `404 StatusForbidden` is more appropriate when the condition is expected by the server.
aptly-dev · Jul 24, 2023 · 1689ee5 · 1689ee5
1 parent 847fd90
commit 1689ee5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/AUTHORS b/AUTHORS
@@ -54,3 +54,4 @@ List of contributors, in chronological order:
 * Boxjan (https://github.com/boxjan)
 * Mauro Regli (https://github.com/reglim)
 * Alexander Zubarev (https://github.com/strike)
+* Nicolas Dostert (https://github.com/acdn-ndostert)
diff --git a/api/mirror.go b/api/mirror.go
@@ -157,7 +157,7 @@ func apiMirrorsDrop(c *gin.Context) {
 			snapshots := snapshotCollection.ByRemoteRepoSource(repo)
 
 			if len(snapshots) > 0 {
-				return &task.ProcessReturnValue{Code: http.StatusInternalServerError, Value: nil}, fmt.Errorf("won't delete mirror with snapshots, use 'force=1' to override")
+				return &task.ProcessReturnValue{Code: http.StatusForbidden, Value: nil}, fmt.Errorf("won't delete mirror with snapshots, use 'force=1' to override")
 			}
 		}