Shut down cleanly when 'api serve' is interrupted #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1219 +/- ##
==========================================
+ Coverage 65.95% 74.87% +8.92%
==========================================
Files 143 143
Lines 16192 16197 +5
==========================================
+ Hits 10679 12128 +1449
+ Misses 4760 3134 -1626
- Partials 753 935 +182
... and 32 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This will properly close the db and, more particularly, flush out any profile files being written. Otherwise, they can end up empty or truncated. Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
refi64
force-pushed
the
api-shutdown
branch
from
4080c4d
to
e1cc8cc
Compare
|
Pushed a slightly cleaned up version. |
randombenj
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will properly close the db and, more particularly, flush out any profile files being written. Otherwise, they can end up empty or truncated.