clean stale entries from the pathCache when removing packages from S3 storage #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as per contributor instructions
Codecov Report
@@ Coverage Diff @@
## master #1224 +/- ##
=======================================
Coverage 65.96% 65.97%
=======================================
Files 143 143
Lines 16188 16189 +1
=======================================
+ Hits 10679 10680 +1
Misses 4756 4756
Partials 753 753
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Superseded by #1241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1223 "file already exists and is different" after un-publishing package from S3
Description of the Change
Properly invalidate the pathCache in the S3 publisher when unpublishing packages and Aptly is running in
api servemode.This prevents Aptly from getting stuck in a broken state where publishing to S3 no longer works.
Checklist
AUTHORS