Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean stale entries from the pathCache when removing packages from S3 storage #1224

Closed
wants to merge 4 commits into from
Closed

clean stale entries from the pathCache when removing packages from S3 storage #1224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30024c3
clean pathCache
sf-nwaller Sep 28, 2023
7934229
Update AUTHORS
sf-nwaller Sep 29, 2023
353c1eb
Merge branch 'master' into clean-s3-pathCache
sf-nwaller Sep 29, 2023
6822ace
Merge branch 'master' into clean-s3-pathCache
sf-nwaller Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,4 @@ List of contributors, in chronological order:
* Alexander Zubarev (https://github.com/strike)
* Nicolas Dostert (https://github.com/acdn-ndostert)
* Ryan Gonzalez (https://github.com/refi64)
* Nic Waller (https://github.com/sf-nwaller)
1 change: 1 addition & 0 deletions s3/public.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ func (storage *PublishedStorage) Remove(path string) error {
return errors.Wrap(err, fmt.Sprintf("error deleting %s from %s", path, storage))
}

delete(storage.pathCache, path)
if storage.plusWorkaround && strings.Contains(path, "+") {
// try to remove workaround version, but don't care about result
_ = storage.Remove(strings.Replace(path, "+", " ", -1))
Expand Down
Loading