Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to aws-sdk-go-v2 #1226

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Oct 13, 2023

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

This PR switches aptly from using aws-sdk-go to aws-sdk-go-v2, the new Go SDK for AWS.
Among many improvement, one is that the endpoints are not stored in global variables, freeing
some memory.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@lebauce lebauce force-pushed the switch-aws-sdk-go-v2 branch 2 times, most recently from 93c43c3 to 88c1f0a Compare October 13, 2023 19:36
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1226 (fc0b4b9) into master (322e5c1) will decrease coverage by 0.03%.
The diff coverage is 59.03%.

@@            Coverage Diff             @@
##           master    #1226      +/-   ##
==========================================
- Coverage   65.96%   65.94%   -0.03%     
==========================================
  Files         143      143              
  Lines       16188    16178      -10     
==========================================
- Hits        10679    10668      -11     
  Misses       4756     4756              
- Partials      753      754       +1     
Files Coverage Δ
s3/public.go 55.95% <59.03%> (-1.57%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lebauce lebauce force-pushed the switch-aws-sdk-go-v2 branch 2 times, most recently from 52ea931 to f0901f3 Compare October 16, 2023 11:19
@randombenj randombenj merged commit 3aaf0a8 into aptly-dev:master Oct 24, 2023
3 of 4 checks passed
@lebauce lebauce mentioned this pull request Oct 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants