Fix/system tests #1245
Merged
Fix/system tests #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neolynx
force-pushed
the
fix/system-tests
branch
from
c3cb245
to
ac6a3ca
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1245 +/- ##
==========================================
- Coverage 74.85% 74.84% -0.01%
==========================================
Files 143 143
Lines 16187 16181 -6
==========================================
- Hits 12117 12111 -6
Misses 3134 3134
Partials 936 936 ☔ View full report in Codecov by Sentry. |
no direct internet download from apt repositories, which over time will change or cease to exist. also migrate to gpg2 on newer ubuntu.
neolynx
force-pushed
the
fix/system-tests
branch
from
7babae8
to
a9da8d0
Compare
randombenj
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Awesome work! @neolynx This finally makes the tests really reproducible and not depending on internet resources!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the system tests permanently, by using a mirror on S3 for all the required files for the tests. No direct internet download, no more flaky tests.
Additionally: