Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpg api: allow self signed and use default gpg version #1246

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Feb 6, 2024

Description of the Change

Self signed GPG keys were refused, which is something aptly should allow, if a repo for mirroring is singed this way.

Also, use the default GPG version, as in the other parts for using GPG keys.

The API also returns the gpg command output, instead of just a failure.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated

@neolynx neolynx requested a review from a team February 6, 2024 20:38
@neolynx neolynx self-assigned this Feb 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.78%. Comparing base (e564b7c) to head (eda1e48).

Files Patch % Lines
api/gpg.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1246   +/-   ##
=======================================
  Coverage   74.78%   74.78%           
=======================================
  Files         143      143           
  Lines       16200    16200           
=======================================
  Hits        12115    12115           
  Misses       3148     3148           
  Partials      937      937           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mfolusiak mfolusiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and use default gpg version is probably redundant in the commit message, otherwise works as expected.

@neolynx neolynx merged commit 6be4f5e into master Apr 3, 2024
4 of 5 checks passed
@neolynx neolynx deleted the fix/gpg-api branch April 6, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants