Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PrivateKey] Add support for AIP80 to Ed25519 and Secp256k1 #38

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

GhostWalker562
Copy link
Contributor

Description

Added support for formatting and parsing private keys with prefixes.

Main Changes:

  • Added static functions to PrivateKey for formatting and parsing AIP-80 private keys
  • Added test cases to Ed25519 and Secp256k1 private keys
  • Added from_hex function that accepts both bytes, hex strings, and AIP-80 compliant strings
  • Changed all existing private keys to have prefix

Test Plan

  • Added testing inside existing test cases for from_hex
  • Added test cases for parsing bytes, hex string, and AIP-80 compliant strings

Related Links

@GhostWalker562 GhostWalker562 self-assigned this Oct 28, 2024
@GhostWalker562 GhostWalker562 merged commit 3e79a83 into main Oct 30, 2024
6 checks passed
@GhostWalker562 GhostWalker562 deleted the support-aip-80 branch October 30, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants