Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read configuration #133

Merged
merged 2 commits into from
Dec 28, 2024
Merged

feat: read configuration #133

merged 2 commits into from
Dec 28, 2024

Conversation

lqxhub
Copy link
Collaborator

@lqxhub lqxhub commented Dec 22, 2024

支持读取配置时区分简单字符串和字符串数组, 现在读取配置中带 ' ' 的配置会自动分割,导致一些配置无法正确读取,为后面支持ACL做好准备

支持读取带单位内存配置, 比如 10M 会自动转成 10,485,760 byte

Summary by CodeRabbit

  • New Features

    • Introduced a new "RAFT" configuration section with options for future use.
    • Added support for memory size configurations with suffix handling.
    • New StringValueArray class for managing arrays of strings.
  • Bug Fixes

    • Improved handling of configuration values to prevent unnecessary resizing.
  • Documentation

    • Updated configuration management structure to enhance clarity and usability.

…ys, and supports memory configuration with units
Copy link

coderabbitai bot commented Dec 22, 2024

Walkthrough

The pull request introduces configuration management enhancements in the Kiwi project, focusing on modifying configuration handling in kiwi.conf, config.cc, and config.h. The changes include adding a new RAFT configuration section, removing RocksDB-related parameters, and improving configuration value management. The modifications streamline string and memory size configuration handling, introduce a new StringValueArray class, and update methods for more efficient and flexible configuration setup.

Changes

File Change Summary
etc/conf/kiwi.conf - Added new "RAFT" section with use-raft no and raft-port-offset 10
- Removed RocksDB-related configuration parameters
src/config.cc - Updated StringValue::SetValue method
- Added MemorySize::SetValue method
- Modified StringValueArray::SetValue method
- Simplified configuration item additions in PConfig constructor
src/config.h - Updated BaseValue constructor
- Simplified StringValue class
- Added new StringValueArray class
- Modified PConfig methods for string and memory size configurations
- Added AddMemorySize method

Poem

🐰 In config's realm, a rabbit's delight,
Strings and sizes now dance just right,
RAFT waits silent, RocksDB takes flight,
Code evolves with elegant might,
Configuration's magic shines bright! 🔧


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 6d9f7d7 and edfda71.

📒 Files selected for processing (1)
  • src/config.h (7 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@luky116 luky116 merged commit f2dfa8d into unstable Dec 28, 2024
5 of 6 checks passed
@AlexStocks AlexStocks deleted the read_config branch January 11, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants