Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 后会丢失原表的元素 #32

Open
panlei-coder opened this issue Aug 31, 2024 · 5 comments
Open

Rename 后会丢失原表的元素 #32

panlei-coder opened this issue Aug 31, 2024 · 5 comments
Assignees

Comments

@panlei-coder
Copy link
Collaborator

Is this a regression?

None

Description

Is this a regression?

Yes

Description

Screenshot 2024-08-18 001901

rename 过程中只是单纯的把原表的metadata发给新表,没有把原表的元素也发转给新表
Screenshot 2024-08-24 120011
Screenshot 2024-08-24 120111

元素放到rocksdb的时候那个key是包含表名的,不只是metavalue的东西,但rename之后没有改变这个原有的表名,用新表名也凑不出这个key,导致的就是元素丢失了

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

images

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

images

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response

@panlei-coder
Copy link
Collaborator Author

@dobet
Copy link
Collaborator

dobet commented Jan 7, 2025

粗略看了一下,应该不止list类型,其他类型也有,此外,还有renamenx命令也存在这个问题

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


After a cursory look, it seems that there are not only list types, but also other types. In addition, the renamenx command also has this problem.

@dobet
Copy link
Collaborator

dobet commented Jan 7, 2025

粗略看了一下,应该不止list类型,其他类型也有,此外,还有renamenx命令也存在这个问题

按照当前的存储结构,可能会存在一个问题,就是原有的数据如果比较多的时候,rename可能会存在性能问题

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


After a cursory look, there should be more than just list types, but other types as well. In addition, the renamenx command also has this problem.

According to the current storage structure, there may be a problem, that is, if there is a lot of original data, rename may have performance problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants