Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add client command #3

Merged
merged 30 commits into from
Nov 16, 2024
Merged

feat: add client command #3

merged 30 commits into from
Nov 16, 2024

Conversation

gukj-spel
Copy link
Collaborator

@gukj-spel gukj-spel commented Aug 27, 2024

add client command and corresponding go test
CLIENT <GETNAME | SETNAME name | LIST [ID client_id1...client_idn] | KILL all | KILL ID client_id | KILL ADDR ip:port>

Summary by CodeRabbit

  • New Features

    • Enhanced client management functionality within the KiwiDB server, allowing for better tracking of connected clients.
    • Improved handling of new connections and disconnections to prevent memory leaks.
  • Bug Fixes

    • Improved clarity and consistency in client information handling.
  • Tests

    • Introduced a new test case in the Admin test suite to validate Redis client commands, enhancing overall test coverage.

Copy link

coderabbitai bot commented Aug 27, 2024

Walkthrough

The changes enhance client management functionality within the KiwiDB server by introducing a new header file, client_map.h, and modifying the src/kiwi.cc file. The OnNewConnection and SetOnClose methods are updated to add and remove clients from a global ClientMap, ensuring proper tracking of connected clients. Additionally, a new test case is added to the tests/admin_test.go file to verify Redis client commands, including setting and retrieving client names and handling client termination. Minor cosmetic changes are made to the src/proto_parser.cc file for code clarity.

Changes

Files Change Summary
src/kiwi.cc Added #include "client_map.h", updated OnNewConnection, SetOnCreate, and SetOnClose methods to manage client connections in ClientMap.
tests/admin_test.go Introduced a new test case "Cmd Client" to validate Redis client commands, including setting and getting client names, and testing client termination.
src/proto_parser.cc Made minor formatting adjustments in Reset and parseStrval methods for improved readability.

Sequence Diagram(s)

sequenceDiagram
    participant ClientMap
    participant KiwiDB
    participant Client

    KiwiDB->>Client: On New Connection
    Client->>ClientMap: Add Client
    KiwiDB->>Client: On Close Connection
    Client->>ClientMap: Remove Client
Loading

🐇 In the burrow, changes abound,
Commands for clients now resound.
With maps and names, we hop with glee,
Managing clients, as easy as can be!
A new dawn for connections bright,
In code we trust, all feels just right! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0cf0dc9 and efe52c0.

📒 Files selected for processing (1)
  • src/proto_parser.cc (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@panlei-coder
Copy link
Collaborator

@panlei-coder

@luky116 luky116 self-requested a review October 19, 2024 13:23
@Risc-lt
Copy link

Risc-lt commented Nov 9, 2024

Please assign it to me.

@Risc-lt Risc-lt self-assigned this Nov 10, 2024
@luky116 luky116 merged commit f3acf2d into unstable Nov 16, 2024
5 checks passed
@AlexStocks AlexStocks deleted the gukaijie branch January 11, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants