-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Resolve the inconsistency between member configuration and log index in snapshot meta #8
base: unstable
Are you sure you want to change the base?
Conversation
…ndex in snapshot meta
WalkthroughThe changes introduce a new method Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
uint64_t replay_point = PSTORE.GetBackend(db_id_)->GetStorage()->GetSmallestFlushedLogIndex(); | ||
node_->set_self_playback_point(replay_point); | ||
node_->set_last_applied_index_and_term(replay_point); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看了下 BRAFT 中没有这个方法
1、解决在真正生成快照时,snapshot meta 保存的成员配置信息和实际的快照数据不一致问题,可能导致新加入的节点跳过成员变更日志,出现配置信息不一致的问题。#9
2、修改 set_self_replay_point 接口为 set_last_applied_index_and_term。
Summary by CodeRabbit
New Features
Bug Fixes
Style