Acane Fem functions #153
Merged
Acane Fem functions #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- start moving functions to femutils
Move common operations to ArcaneFEMFunctions for code refactoring. - New Real3x3 function for gradient
add operator + subtraction - unary negation operator
scalar multiplation outer vector product
For Bary Center calculation For Dirichlet BC
- source term functions - Dirichlet point function - Manufactured Solution function - Quad area function
- Useful for Quad/Tetra mesh with 4 entities - Introduced outer product operator ^ for 4x4
- introduced computeGradientXQuad4 and computeGradientYQuad4
1 task
Dirichlet is now added in an optimized way
Use templated Lambda fuctions for bilinear assembly
grospelliergilles
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Thanks for the great PR.
It is ok for me to merge.
In the future we may need to change some minor things in ArcaneFemFunctions.h:
- Do not directly use the types generated from CaseOptions to make it more generic.
- Use views instead of
VariableNodeReal3&to arguments. This will make these functions available on GPU. The view class isVariableNodeReal3InView. Maybe we can add it as a field of a helper class so we do not need to pass it as a parameter for each compute function.
|
Thank you @grospelliergilles for the reviews, I will keep your suggestions in a Todo list, definitely what you suggest will be helpful in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is to create common functions base between modules and to optimize modules this way.