feat[poisson]: Support 3D mesh with NodeWise CSR #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toutane
changed the title
toutane
force-pushed
the
dev/cal-poisson-nodewise-csr-3d-support
branch
from
e2b5f99
to
818d1fa
Compare
mohd-afeef-badri
requested changes
Oct 9, 2024
|
|
||
| m_csr_matrix.setCoordinates(diagonal_entry, diagonal_entry); | ||
|
|
||
| for (Edge edge : node.edges()) { |
There was a problem hiding this comment.
test via node-node connectivity in future
poisson/NodeWiseCsrBiliAssembly.cc
Outdated
| auto node_dof(m_dofs_on_nodes.nodeDoFConnectivityView()); | ||
|
|
||
| // Compute the number of nnz and initialize the memory space | ||
| Int32 nnz = nbFace() * 2 + nbNode(); | ||
| m_csr_matrix.initialize(m_dof_family, nnz, nbNode()); | ||
| Integer nbnde = nbNode(); |
There was a problem hiding this comment.
Int64 should be a better choice instead of Interger. we should do the same for nnz
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 64.00% 63.39% -0.62%
==========================================
Files 57 57
Lines 8255 8335 +80
Branches 1034 1050 +16
==========================================
Hits 5284 5284
- Misses 2696 2776 +80
Partials 275 275 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L-shape_3D_nwcsr_gpu