Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps #29

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Deps #29

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore

This file was deleted.

2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

To maintain a high standard of quality in our releases, before merging every pull request we ask that you've completed the following:

- [ ] Forked the repo and created your branch from `master`
- [ ] Forked the repo and created your branch from `main`
- [ ] Made sure tests pass (run `npm it` from the repo root)
- [ ] Expanded test coverage related to your changes:
- [ ] Added and/or updated unit tests (if appropriate)
Expand Down
15 changes: 11 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
# Go
steps:
- name: Check out repo
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -40,7 +40,14 @@ jobs:
- name: Install
run: npm install

- name: Test (Node.js <= 16.x)
if: matrix.node-version <= '16.x'
run: npm run test:nolint
env:
CI: true

- name: Test
if: matrix.node-version > '16.x'
run: npm test
env:
CI: true
Expand All @@ -67,10 +74,10 @@ jobs:
# Go
steps:
- name: Check out repo
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: lts/*
registry-url: https://registry.npmjs.org/
Expand Down
9 changes: 9 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@

---

## [4.0.5] 2024-04-29

### Changed

- Updated dependencies
- Updated `package.json` `engines.node` property to reflect changes from v4

---

## [4.0.3 - 4.0.4] 2024-03-25

### Changed
Expand Down
10 changes: 10 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
const arc = require('@architect/eslint-config')

module.exports = [
...arc,
{
ignores: [
'test/mock',
],
},
]
22 changes: 10 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,41 +9,39 @@
"scripts": {
"lint": "eslint . --fix",
"test": "npm run lint && npm run coverage",
"test:nolint": "npm run coverage",
"test:unit": "cross-env tape 'test/unit/**/*-test.js' | tap-arc",
"coverage": "cross-env nyc --reporter=lcov --reporter=text npm run test:unit",
"test:integration": "cross-env tape test/integration/**/*-test.js | tap-arc",
"rc": "npm version prerelease --preid RC"
},
"license": "Apache-2.0",
"engines": {
"node": ">=14"
"node": ">=16"
},
"repository": {
"type": "git",
"url": "https://github.com/architect/destroy.git"
},
"dependencies": {
"@architect/inventory": "~4.0.4",
"@architect/utils": "~4.0.4",
"@aws-lite/client": "^0.20.0",
"@aws-lite/cloudformation": "^0.0.4",
"@architect/inventory": "~4.0.5",
"@architect/utils": "~4.0.6",
"@aws-lite/client": "^0.21.1",
"@aws-lite/cloudformation": "^0.0.5",
"@aws-lite/cloudwatch-logs": "^0.0.4",
"@aws-lite/s3": "^0.1.20",
"@aws-lite/s3": "^0.1.21",
"@aws-lite/ssm": "^0.2.3",
"minimist": "~1.2.8",
"run-parallel": "~1.2.0",
"run-waterfall": "~1.1.7"
},
"devDependencies": {
"@architect/deploy": "~5.0.3",
"@architect/eslint-config": "^2.1.2",
"@architect/deploy": "~5.0.5",
"@architect/eslint-config": "^3.0.0",
"cross-env": "~7.0.3",
"eslint": "~8.57.0",
"eslint": "~9.1.1",
"nyc": "~15.1.0",
"tap-arc": "~1.2.2",
"tape": "~5.7.5"
},
"eslintConfig": {
"extends": "@architect/eslint-config"
}
}
2 changes: 1 addition & 1 deletion src/_delete-bucket.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,6 @@ module.exports = function deleteBucketContents ({ aws, bucket: Bucket }, callbac
.catch(err => callback(err))
}
else callback()
}
},
], callback)
}
6 changes: 3 additions & 3 deletions src/_ssm.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = {
getDeployBucket: function getDeployBucket (aws, appname, callback) {
aws.ssm.GetParameter({
Name: `/${appname}/deploy/bucket`,
WithDecryption: true
WithDecryption: true,
})
.then(data => {
let value = data?.Parameter?.Value ? data.Parameter.Value : null
Expand All @@ -24,7 +24,7 @@ module.exports = {
aws.ssm.GetParametersByPath({
Path: rootPath,
Recursive: true,
paginate: true
paginate: true,
})
.then(data => {
if (data?.Parameters?.length) {
Expand Down Expand Up @@ -63,5 +63,5 @@ module.exports = {
deleteThings()
}
})
}
},
}
2 changes: 1 addition & 1 deletion src/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ async function main (opts = {}) {
now: args.now,
retries: args.timeout ? 15 : 999,
stackname: args.name,
update
update,
}

update.status(`Destroying ${env} environment`)
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ module.exports = function destroy (params, callback) {
})
}
check()
}
},

], callback)

Expand Down