Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove geometry simplification in radiation #3718

Open
reyery opened this issue Dec 3, 2024 · 0 comments
Open

Remove geometry simplification in radiation #3718

reyery opened this issue Dec 3, 2024 · 0 comments
Assignees
Labels
feature-radiation priority-must-have These requirements are critical and must be included in CEA
Milestone

Comments

@reyery
Copy link
Member

reyery commented Dec 3, 2024

During the radiation simulation, one of the steps include simplifying the building geometries. This is done to reduce the amount of surfaces being used for the simulation, making it faster.

However, this produces some irregularities when trying to compare/align the sensor point values with the original building surfaces, especially around curved areas where vertices are close together (as seen by the screenshot below).

image

I propose to remove the simplification step from radiation and instead move it to zone-helper.

I believe that radiation should run based on the actual footprints of the input geometries, and not one that is produced and discarded at the end of the simulation. Therefore, it should be done at the point of importing geometries (user should be given a choice) either when fetching from OSM or importing own geometries. So the input building geometries would be the single source of truth of the building surfaces.

@reyery reyery self-assigned this Dec 3, 2024
@ShiZhongming ShiZhongming added priority-must-have These requirements are critical and must be included in CEA feature-radiation labels Dec 4, 2024
@reyery reyery added this to the CEA4 - Mar'25 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-radiation priority-must-have These requirements are critical and must be included in CEA
Projects
None yet
Development

No branches or pull requests

2 participants