Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Replacements (#430) #435

Closed
wants to merge 3 commits into from
Closed

Registry Replacements (#430) #435

wants to merge 3 commits into from

Conversation

qyl27
Copy link

@qyl27 qyl27 commented Sep 21, 2023

Replace vanilla items with register() on fabric.
(Tested on my machine.)

Signed-off-by: 秋雨落 <i@rain.cx>
Signed-off-by: 秋雨落 <i@rain.cx>
Signed-off-by: 秋雨落 <i@rain.cx>
@MaxNeedsSnacks
Copy link
Member

Hmm, honestly I would prefer if registry replacement was explicit on both instead of implicit, so maybe we should instead consider making a registerOrOverride method?

@qyl27
Copy link
Author

qyl27 commented Jan 7, 2024

Hmm, honestly I would prefer if registry replacement was explicit on both instead of implicit, so maybe we should instead consider making a registerOrOverride method?

Well, maybe that's right.
I will change it to a explicit method named registerOrOverride.

@shedaniel
Copy link
Member

After some discussion on Discord, I believe we don't want to support registry replacements seeing how NeoForge no longer supports it after the Registry Rework and fabric never encouraged it. Alternative solutions should be used instead, albeit mixins or etc.

Some checks can be added to the forge register() method to warn potential registry replacements instead.

@shedaniel shedaniel changed the title A possible fix for #430. Registry Replacements (#430) Jan 10, 2024
@qyl27
Copy link
Author

qyl27 commented Jan 10, 2024

After some discussion on Discord, I believe we don't want to support registry replacements seeing how NeoForge no longer supports it after the Registry Rework and fabric never encouraged it. Alternative solutions should be used instead, albeit mixins or etc.

Some checks can be added to the forge register() method to warn potential registry replacements instead.

Ah, okay.

@Jab125
Copy link
Member

Jab125 commented Apr 13, 2024

After some discussion on Discord, I believe we don't want to support registry replacements seeing how NeoForge no longer supports it after the Registry Rework and fabric never encouraged it. Alternative solutions should be used instead, albeit mixins or etc.

Some checks can be added to the forge register() method to warn potential registry replacements instead.

@Jab125 Jab125 closed this Apr 13, 2024
@qyl27 qyl27 deleted the 1.20 branch April 13, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants