Add a JSON file with information on cpuid #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isuruf I added a JSON file with the information we need from |
|
Looks great. Thanks. |
2 tasks
tgamblin
pushed a commit
to archspec/archspec
that referenced
this pull request
Feb 17, 2024
This PR builds on #129 and #149 to add support for Windows. Features detection is done using `cpuid`. The `cpuid` calls that we need to detect features are in archspec/archspec-json#86. We also forked [archspec/cpuid](https://github.com/archspec/cpuid) and use it here as a submodule. Modifications: - [x] Add a new method to detect CPU features and vendor using `cpuid` - [x] Add unit tests for the new method, including Windows - [x] update archspec-json --------- Co-authored-by: Isuru Fernando <isuruf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll use this information to detect features on Windows, since the OS doesn't expose them in any other way.
Modifications:
cpuid.jsoncpuid.jsoncpuid_schema.jsoncpuid(I guess a CSV collection of input and output from the registers)