PE-4923: Introduces methods for getting file name and extension #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return contentType.substring(contentType.lastIndexOf('/') + 1); | ||
| } | ||
|
|
||
| String getBasenameWithoutExtension({required String filePath}) { |
There was a problem hiding this comment.
@matibat , can you add the withoutExtension parameter and implement both options: with and without extension?
There was a problem hiding this comment.
I'd prefer to introduce a new separate method when needed. 🙏
test/src/utils/path_utils_test.dart
Outdated
Comment on lines
117
to
121
| test('should return the file type from mimetype', () { | ||
| final type = getFileTypeFromMime(contentType: 'application/pdf'); | ||
|
|
||
| expect(type, 'pdf'); | ||
| }); |
There was a problem hiding this comment.
@matibat please add more test cases here. Chat GPT can generate for you.
test/src/utils/path_utils_test.dart
Outdated
Comment on lines
126
to
130
| final basename = getBasenameWithoutExtension( | ||
| filePath: '/hola/que/tal/file.pdf', | ||
| ); | ||
|
|
||
| expect(basename, 'file'); |
There was a problem hiding this comment.
Same comment as before. Some test cases:
- filePath: 'file.pdf'
- filePath: 'file.pdf.txt'
- filePath: 'file' <- no extension on the file name (is it possible to get using IOFile?)
thiagocarvalhodev
requested changes
Nov 7, 2023
There was a problem hiding this comment.
We need more test cases on the unit tests. This comment is optional: https://github.com/ar-io/ardrive_io/pull/19/files#r1385438373
|
Introduced more test cases, @thiagocarvalhodev . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.