Merge pull request #176 from arduino-libraries/iContentLength_wraparound

Make sure iContentLength doesn't wrap around due to malformed packets
arduino-libraries · Jul 25, 2024 · 25f54e9 · 25f54e9
2 parents 6f2659d + 1a3fb98
commit 25f54e9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/HttpClient.cpp b/src/HttpClient.cpp
@@ -819,7 +819,11 @@ int HttpClient::readHeader()
     case eReadingContentLength:
         if (isdigit(c))
         {
-            iContentLength = iContentLength*10 + (c - '0');
+            long _iContentLength = iContentLength*10 + (c - '0');
+            // Only apply if the value didn't wrap around
+            if (_iContentLength > iContentLength) {
+                iContentLength = _iContentLength;
+            }
         }
         else
         {