Changing return type of 'requestFrom' from uint8_t to size_t allows t…

…he function to return the correct amount of bytes read (since internally it's already a size_t which is downcast to a uint8_t upon returning it. (#132)
arduino · Dec 10, 2020 · 4f19438 · 4f19438
1 parent 4bd75df
commit 4f19438
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/api/HardwareI2C.h b/api/HardwareI2C.h
@@ -36,8 +36,8 @@ class HardwareI2C : public Stream
     virtual uint8_t endTransmission(bool stopBit) = 0;
     virtual uint8_t endTransmission(void) = 0;
 
-    virtual uint8_t requestFrom(uint8_t address, size_t len, bool stopBit) = 0;
-    virtual uint8_t requestFrom(uint8_t address, size_t len) = 0;
+    virtual size_t requestFrom(uint8_t address, size_t len, bool stopBit) = 0;
+    virtual size_t requestFrom(uint8_t address, size_t len) = 0;
 
     virtual void onReceive(void(*)(int)) = 0;
     virtual void onRequest(void(*)(void)) = 0;