Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isAscii: avoid dependency on _GNU_SOURCE #176

Merged
merged 5 commits into from
Dec 21, 2022
Merged

isAscii: avoid dependency on _GNU_SOURCE #176

merged 5 commits into from
Dec 21, 2022

Conversation

facchinm
Copy link
Member

@facchinm facchinm commented Dec 20, 2022

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 96.11% // Head: 96.20% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (981a9f6) compared to base (c8ee90f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   96.11%   96.20%   +0.08%     
==========================================
  Files          13       13              
  Lines         953      949       -4     
==========================================
- Hits          916      913       -3     
+ Misses         37       36       -1     
Impacted Files Coverage Δ
api/WCharacter.h 100.00% <100.00%> (ø)
api/Print.cpp 95.20% <0.00%> (-0.03%) ⬇️
api/Stream.cpp 91.42% <0.00%> (+0.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@carlosperate
Copy link

Thanks for the PR @facchinm!

I haven't test it yet, but doesn't it also need an custom implementation of toascii(), as used in toAscii()?

// Converts c to a 7-bit unsigned char value that fits into the
// ASCII character set, by clearing the high-order bits.
inline int toAscii(int c)
{
return toascii (c);
}

@facchinm
Copy link
Member Author

@carlosperate thanks for pointing that out, I added the patch and test for that function too

@facchinm facchinm merged commit 691d84d into master Dec 21, 2022
@per1234 per1234 added the bug label Dec 21, 2022
@aentinger aentinger deleted the patch_isascii branch November 28, 2023 07:46
@aentinger aentinger restored the patch_isascii branch November 28, 2023 07:46
@aentinger aentinger deleted the patch_isascii branch November 28, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants