-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add String::isEmpty() #220
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 16 16
Lines 1075 1075
=======================================
Hits 1027 1027
Misses 48 48
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alranel ☕ 👋
Two minor points:
- Indendation does not match the rest of the file (probably a TAB vs SPACE issue?)
- Please provide a unit test that hard-codes the API expectation for this function.
Hi @aentinger! |
I'm a spaces guy myself but since there are tabs in that file ... 🤷 got-to-go with the flow I suppose 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for applying my suggestions! 🙇
This PR adds a tiny inline
isEmpty()
method to the String class. This is borrowed from the ESP32 core which made it popular.