-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Tone.cpp to allow specifying pin state on noTone #532
base: master
Are you sure you want to change the base?
Conversation
Memory usage change @ 380f045
Click for full report table
Click for full report CSV
|
@per1234 the tests show errors in their internal workings? |
Hi @Foxunderground0. Thanks for your pull request!
That is correct. There was a transient degradation of the network services used by the continuous integration system earlier. This caused spurious failures of some workflow jobs across GitHub. I re-ran the failing jobs and everything is now passing. I apologize for any confusion these spurious failures might have caused. |
Pull request addresses issue #489. Adds support for passive buzzers with inverted logic, which beep on LOW instead of HIGH. The current work-around is to call digitalWrite(pin, HIGH) after calling noTone(), however it causes a "click" sound after the tone has played.
With this change, the pin state can be specified in Tone.cpp is inverted, so passive buzzers with either normal or inverted logic can be used with tone() without any work-around.
The original function is still present, the new function builds on that as a template.
First pull request 🚀🚀🚀! So glad I got here👋