Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the name not being present on the index #207

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fix the name not being present on the index #207

merged 1 commit into from
Jul 31, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jul 31, 2023

Before this we have to have the core installed to retrieve this info. It's not optimal to install a whole core for a name only.

This problem became clear when running: arduino-fwuploader firmware list:

Board                       FQBN                                Module     Version
[...]
Arduino MKR WiFi 1010       arduino:samd:mkrwifi1010            NINA     ✔ 1.5.0
[...]
Arduino Uno WiFi Rev2       arduino:megaavr:uno2018             NINA     ✔ 1.5.0  
[...]
Arduino Nano RP2040 Connect arduino:mbed_nano:nanorp2040connect NINA       1.4.8  
Arduino Nano RP2040 Connect arduino:mbed_nano:nanorp2040connect NINA     ✔ 1.5.0  
                            arduino:renesas_uno:unor4wifi       ESP32-S3   0.1.0  
                            arduino:renesas_uno:unor4wifi       ESP32-S3   0.2.0  
                            arduino:renesas_uno:unor4wifi       ESP32-S3 ✔ 0.2.1  

Note the missing board name:
This is caused by the absence of this field in the plugin_firmware_index.json.
This PR aims to add this info directly without needing to install the whole core

Before this we have to have the core installed to retrieve this info.
It's not optimal to install a whole core for a name only
@umbynos umbynos added the topic: infrastructure Related to project infrastructure label Jul 31, 2023
@umbynos umbynos self-assigned this Jul 31, 2023
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOOOICE

@umbynos umbynos merged commit 61e036b into main Jul 31, 2023
21 checks passed
@umbynos umbynos deleted the fix-name branch July 31, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants