Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image support. #17

Open
ShivamB25 opened this issue Sep 9, 2024 · 5 comments
Open

Docker image support. #17

ShivamB25 opened this issue Sep 9, 2024 · 5 comments

Comments

@ShivamB25
Copy link

please. i can also try making a image with nvida cuda as base layer

@0xtempest
Copy link

I have a docker setup working with this, and I have optimized API changes as well, I'm planning to make a large PR soon once I fix all the LoRA issues.

@aredden
Copy link
Owner

aredden commented Sep 10, 2024

Ah cool! @0xtempest If it's a very large PR, could it be done in pieces? I would like to be able to test each change individually since for a very large PR it can be tough to figure out what is doing what. Also yeah, docker should be relatively simple to set up since you can just use a pytorch container and install the requirements.

@0xtempest
Copy link

Yeah I can break it down in smaller PR's, probably will be early next week as there's a lot to clean up

@ShivamB25
Copy link
Author

@0xtempest Could you please keep your fork (please add updates). and i would love to test around

@ShivamB25
Copy link
Author

@0xtempest possible ? i would also like to try helping with lora's issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants