-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: k8s client 0.26 #15571
Closed
Closed
chore: k8s client 0.26 #15571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fengshunli <1171313930@qq.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> # Conflicts: # applicationset/controllers/applicationset_controller.go # applicationset/controllers/applicationset_controller_test.go # docs/operator-manual/server-commands/argocd-server.md # docs/operator-manual/upgrading/2.7-2.8.md # docs/user-guide/sync-options.md # go.mod # go.sum
This is based on argoproj#13965, which this time hopefully has been updated and merged correctly to a currentish version of argo-cd. The main difference here is that the gitops version is based upon argoproj/gitops-engine#537, which should maintain pre-existing labels and annotations. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
This should work exactly the same as before. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #15571 +/- ##
==========================================
- Coverage 50.03% 49.99% -0.05%
==========================================
Files 266 266
Lines 45681 45754 +73
==========================================
+ Hits 22857 22874 +17
- Misses 20590 20634 +44
- Partials 2234 2246 +12
☔ View full report in Codecov by Sentry. |
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
This reverts commit 99a56ea. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #13965, which this time hopefully has been updated
and merged correctly to a currentish version of argo-cd.
The main difference here is that the gitops version is based upon
argoproj/gitops-engine#537, which should maintain pre-existing
labels and annotations.
Checklist: