test: testing gitops-engine fork pr 565

[asaf-erlich]

This PR is just for testing argoproj/gitops-engine#565, I don't think it actually needs to be merged but I'm not sure. Following instructions from argoproj/gitops-engine#556 (comment)

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[asaf-erlich]

@crenshaw-dev any guidance on how to address the failed CI in this PR?

[crenshaw-dev]

@asaf-erlich check the logs under the image build details... I see some errors relating to client-go:

Error: #41 101.8 server/application/application.go:119:40: cannot use appBroadcaster (variable of type Broadcaster) as "k8s.io/client-go/tools/cache".ResourceEventHandler value in argument to appInformer.AddEventHandler: Broadcaster does not implement "k8s.io/client-go/tools/cache".ResourceEventHandler (wrong type for method OnAdd)

(one of several)

After that, I'd pull up argo-cd in some go IDE and just follow the red squigglies to start finding/tackling bugs. My guess is most are related to modified or removed methods in the k8s libraries.

[crenshaw-dev]

Ah there are also some helpful messages at the bottom of the diff. https://github.com/argoproj/argo-cd/pull/16967/files

[blakepettersson]

Hi @asaf-erlich,

Thanks for the PR! This will be superseded by #17491, and it seems pretty likely that that will be the PR to be merged. Closing for now - if you feel otherwise feel free to reopen.