-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update gitops engine for force sync option (#5882) #17866
chore: update gitops engine for force sync option (#5882) #17866
Conversation
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
bb82c02
to
3027116
Compare
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
3027116
to
13fb5a9
Compare
@pasha-codefresh , Could you please review when you have some time? |
@CodiumAI-Agent /review |
PR Review
Code feedback:
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
@@ -165,6 +165,17 @@ metadata: | |||
argocd.argoproj.io/sync-options: Replace=true | |||
``` | |||
|
|||
## Force Sync | |||
|
|||
For certain resources you might want to delete and recreate. e.g. job resources that should run every time when syncing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pasha-codefresh
thank you comment !
I added warning description of force sync options.
LGTM, just small comment @kkk777-7 |
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
f3d8504
to
b59300c
Compare
Thank you for implementing this! Could we please get this set up for release as part of v2.10.8? Not familiar with the release process for this repo. |
Gentle nudge :) Could this be included in a patch release soon? This is the last piece needed for ArgoCD to handle jobs for us well. @pasha-codefresh |
Same, looks like it didn't make it into the 2.11.0 release, was really waiting for this change. Any status update on when should we expect this? |
We need cherry-pick it, let me see if i can help here @eitan-papaya |
/cherry-pick release-2.10 |
Cherry-pick failed with |
@eitan-papaya @tybook going to cherry-pick it into 2.10, 2.11, let me know if you need it for 2.8 or 2.9 |
@pasha-codefresh |
@pasha-codefresh , I just found this thread, is there any chance you could also cherry-pick it into the 2.9 release? I've seen your 2 PRs to the 2.10 and 2.11 release branches, it looks straightforward and I could give it a shot if you prefer, but as a non-contributor I suspect it would take me longer to get it all approved / merged in, etc. |
@digitalyuki could you please just cherry-pick it? i will make sure that it is reviewed and merged. Let me know if you meed any issues |
@pasha-codefresh here's my attempt to cherry-pick it to for 2.9... Not sure why it failed the CI but committing to this repo is new for me. |
@pasha-codefresh Thanks again for the quick response. When could we expect a release including this (either 2.10/2.11)? I saw in the docs:
So wanted to understand better if it's expected in the upcoming days or that it can happen sooner given a request. |
I will do release during next week, approximately Tuesday |
…goproj#17866) * chore: update gitops engine version Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add: e2e and docs for force sync options Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * docs: Add warning description of force sync options Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
…goproj#17866) * chore: update gitops engine version Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add: e2e and docs for force sync options Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * docs: Add warning description of force sync options Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
@pasha-codefresh Wanted to know, if we included this in a patch release for 2.10/2.11? |
Update gitops-engine for enable force sync option. Also, add e2e and docs.
Ref: argoproj/gitops-engine#560
Related Issue number
Closes #5882
Closes #7459
Closes #9163
Checklist: