feat(appset): filtering repos by archived status #20736
Open
+3,241
−4,982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adam_buran <adam.buran@airbnb.com>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
aburan28
force-pushed
the
adam--scm-filtering-archived-repos
branch
from
f0a0621
to
af0b921
Compare
aburan28
changed the title
Signed-off-by: adam_buran <adam.buran@airbnb.com>
Signed-off-by: adam_buran <adam.buran@airbnb.com>
14 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20736 +/- ##
==========================================
- Coverage 55.17% 55.09% -0.08%
==========================================
Files 324 324
Lines 55259 55265 +6
==========================================
- Hits 30487 30450 -37
- Misses 22158 22192 +34
- Partials 2614 2623 +9 ☔ View full report in Codecov by Sentry. |
ishitasequeira
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Overall PR looks good!! @aburan28 can you resolve the conflicts?
| @@ -160,6 +165,7 @@ spec: | |||
| * `allBranches`: By default (false) the template will only be evaluated for the default branch of each repo. If this is true, every branch of every repository will be passed to the filters. If using this flag, you likely want to use a `branchMatch` filter. | |||
| * `tokenRef`: A `Secret` name and key containing the Gitea access token to use for requests. If not specified, will make anonymous requests which have a lower rate limit and can only see public repositories. | |||
| * `insecure`: Allow for self-signed TLS certificates. | |||
| * `excludeArchivedRepos`: exclude repositories that are archived. defaults to false\ | |||
There was a problem hiding this comment.
nit: remove the additional \ at the end?
Signed-off-by: Adam Buran <aburan28@gmail.com>
Signed-off-by: Adam Buran <aburan28@gmail.com>
There was a problem hiding this comment.
@aburan28 , looks like the CI are failing with your latest changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a filter on repos to choose if archived repos are to be included in the scm generator.
For now this only includes github and gitea.
Closes [ISSUE https://github.com//issues/18531]
Checklist: