fix: downgrade normalize-url to avoid crash in safari #6703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
10 tasks
rbreeze
approved these changes
Jul 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #6703 +/- ##
=======================================
Coverage 41.30% 41.30%
=======================================
Files 156 156
Lines 20702 20702
=======================================
Hits 8550 8550
Misses 10944 10944
Partials 1208 1208 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Closes #6701
Safari cannot render Argo CD UI due to sindresorhus/normalize-url#105 . The normalize-url version was upgraded to resolve security vulnerability. According to https://snyk.io/vuln/npm:normalize-url we can as well downgrade to 4.3.0 . Argo CD does not really need features of never version and we can safely downgrade and remove vulnerability as well.